Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CF writer crashing with netcdf development version #2961

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix CF writer crashing with netcdf development version #2961

merged 2 commits into from
Nov 4, 2024

Conversation

sfinkens
Copy link
Member

Fix CF writer crashing with netcdf development version. I'm not so happy with the string replacement, but it's the best I came up with. Alternatives:

  • LooseVersion from distutils, but that's deprecated and not comparable with packaging.version.Version
  • Report the issue upstream. But I don't think there's a big chance for success. The netcdf-C library probably won't care about PEP440 and the netCDF4 Python module will probably want to keep the original value.

@sfinkens sfinkens changed the title Fix CF writer crashing with netcdf devel Fix CF writer crashing with netcdf development version Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (d6b8d01) to head (8df630d).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2961      +/-   ##
==========================================
- Coverage   96.09%   96.08%   -0.02%     
==========================================
  Files         377      377              
  Lines       55125    55134       +9     
==========================================
+ Hits        52975    52976       +1     
- Misses       2150     2158       +8
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11626210846

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.192%
Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 11519685240: -0.01%
Covered Lines: 53220
Relevant Lines: 55327
💛 - Coveralls

djhoese
djhoese reviewed Oct 31, 2024
View reviewed changes
satpy/writers/cf_writer.py Outdated Show resolved Hide resolved
@sfinkens sfinkens requested a review from djhoese November 4, 2024 09:00
@djhoese
Copy link
Member

djhoese commented Nov 4, 2024

@sfinkens Feel free to merge (I assume you have permissions), but otherwise let me know if you want me to do it.

@sfinkens sfinkens merged commit f05cc8f into pytroll:main Nov 4, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese djhoese approved these changes

@mraspaud mraspaud Awaiting requested review from mraspaud mraspaud is a code owner

Assignees
No one assigned
Labels
bug component:writers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netcdf4 version causes error
3 participants
@sfinkens @coveralls @djhoese